Re: Re: [VOTE] Introduce session.lock, session.lazy_write and session.lazy_destory

From: Date: Thu, 30 Jan 2014 07:30:35 +0000
Subject: Re: Re: [VOTE] Introduce session.lock, session.lazy_write and session.lazy_destory
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
Hi Yasuo,

On Thursday 30 January 2014 16:17:58 Yasuo Ohgaki wrote:
> 
> I also notice other issue when closely looking at current code.
...
> 
> However, when write() is called, it always close opened fd to address
> changed session ID.

I don't see that. You mean by the call to ps_files_close() within 
ps_files_open(), and that close() call dropping the lock? That is conditional 
on either data->fd < 0 (no file open, just a superfluous call to 
ps_file_close()), or key != lastkey (and then a _different_ file will be 
opened and locked for writing).

best regards
  Patrick


Thread (42 messages)

« previous php.internals (#71784) next »