Remove unused /embedded/projects/:identifier route
#1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as we can tell, this route is no longer used anywhere [1]. This was originally added in Mar 2022 in #72 for the "ESA demo". I suspect we now achieve a similar effect by using the web component rather than using this route in combination with an `iframe`. I found it confusing to see both the `/:locale/embed/viewer/:identifier` and this route in the `AppRoutes` component. Removing this one makes the code less confusing. I've also removed the now redundant `embedded` property on the `ProjectComponentLoader` component and the similarly redundant call to `useEmbeddedMode` which is a no-op when `embedded` is `false`. [1]: https://github.com/search?q=org%3Araspberrypilearning+embedded%2Fprojects&type=code
floehopper
force-pushed
the
remove-unused-embedded-projects-route
branch
from
ba60622 to
846382e
Compare
|
|
loiswells97
reviewed
May 17, 2024
sra405
previously approved these changes
May 17, 2024
floehopper
added a commit
that referenced
this pull request
Jun 3, 2024
Strictly speaking, I think the fact we’ve removed a route [1] means we should probably bump the major version, but given (a) we’re still on v0.x.x which is less strict about semantic versioning; and (b) we’re confident nothing is using that route any more, we've decided [2] to just to bump the minor version, i.e. go for release v0.24.0. [1]: #1013 [2]: https://raspberrypifoundation.slack.com/archives/C02JBAA2NFP/p1717429841916009
Merged
floehopper
added a commit
that referenced
this pull request
Jun 4, 2024
### Added - Add `project_name_editable` attribute to web component (#1009) - Fires custom event when the theme changes (#1015) - Add `output_only` attribute to web component (#1019 & originally #782) - Add `assets_identifier` attribute to web component (#1019 & originally #901) - Enhance `code` attribute on web component to override project main component content (#1019 & originally #901) - Add `runCode`, `stopCode` & `rerunCode` methods to web component (#1019 & originally #899) - Send error details in "editor-runCompleted" event (#1019 & originally #915) - Return error details to web component (#1019 & originally #915) - Add `output_panels` attribute to web component (#1019 & originally #909) ### Changed - Remove unused `/embedded/projects/:identifier` route (#1013) ### Fixed - Remove unused `REACT_APP_LOGIN_ENABLED` env var (#1006) - Fix infinite remix loop when `BYPASS_AUTH` set in `editor-api` (#1007) - Fixes for docker-compose.yml (#1008) - Fix deprecation warnings in GitHub Actions (#1011) - Removed unused `isEmbedded` param from `useProject` call in `EmbeddedViewer` (#1016) - Improvements to Cypress specs in CI (#1017) - Fix warnings and verbose output when starting Webpack Dev Server (#1018) - Add e2e spec for project remix behaviour in web component (#1020) - Fix initial value of `user` in `WebComponentLoader` (#1021) - Make `authKey` in e2e web component spec more realistic (#1022) - Remove unused `ComponentStore` (#1023)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as we can tell, this route is no longer used anywhere.
This was originally added in Mar 2022 in #72 for the "ESA demo". I suspect we now achieve a similar effect by using the web component with its
embeddedattribute set totrue, rather than using aniframewith itssrcset to this route.I found it confusing to see both the
/:locale/embed/viewer/:identifierand this route in theAppRoutescomponent. Removing this one makes the code less confusing.I've also removed the now redundant
embeddedproperty on theProjectComponentLoadercomponent and the similarly redundant call touseEmbeddedModewhich is a no-op whenembeddedisfalse.