Fix warnings and verbose output when starting Webpack Dev Server #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floehopper
temporarily deployed
to
previews/fix-warnings-and-verbose-output
GitHub Actions
Inactive
|
|
conorriches
previously approved these changes
May 23, 2024
We were seeing multiple warnings when the app started up and therefore
also when running the Cypress specs in CI. The warnings were like this:
Replace fill-available to stretch, because spec had been changed
The change from using "fill-available" to "stretch" in various CSS
dimension-related properties seems to have been a change to the CSS spec
a long time ago and I'm _fairly_ confident all browsers have supported
it for some time. Useful references:
* https://developer.mozilla.org/en-US/docs/Web/CSS/block-size
* https://developer.mozilla.org/en-US/docs/Web/CSS/width#browser_compatibility
* https://caniuse.com/?search=width%3A%20fill-available
* https://caniuse.com/?search=width%3A%20stretch
I've just done a global search & replace "fill-available" -> "stretch"
in this commit and this seems to fix the warnings and it doesn't seem to
have broken anything.
Previously we were seeing the following deprecation warning when running
the app and thus also when running the Cypress specs in CI:
Using 'compiler' as the first argument is deprecated. Please use
'options' as the first argument and 'compiler' as the second argument.
Reversing the arguments as per this migration guide [1] seems to fix the
warning.
[1]: https://github.com/webpack/webpack-dev-server/blob/master/migration-v4.md#deprecations
Previously we were seeing the following deprecation warning when running
the app and thus also when running the Cypress specs in CI:
`listen` method is deprecated in favor of async `start` or
`startCallback` methods
Following this migration guide [1] seems to fix the warning.
[1]: https://github.com/webpack/webpack-dev-server/blob/master/migration-v4.md#deprecations
I'm not convinced that we need to see these stats every time we start the dev server, especially when we're running both the app and the web component container, and they make it harder to see if any important warnings are being displayed.
I followed the instructions in the warning to run `npx
update-browserslist-db@latest` and saw the following output:
Browserslist: caniuse-lite is outdated. Please run:
npx update-browserslist-db@latest
Why you should do it regularly: https://github.com/browserslist/update-db#readme
Latest version: 1.0.30001618
Updating caniuse-lite version
$ yarn up -R caniuse-lite
caniuse-lite has been successfully updated
No target browser changes
floehopper
force-pushed
the
fix-warnings-and-verbose-output
branch
from
f34ddb2 to
644240f
Compare
|
chrisroos
approved these changes
May 23, 2024
Merged
floehopper
added a commit
that referenced
this pull request
Jun 4, 2024
### Added - Add `project_name_editable` attribute to web component (#1009) - Fires custom event when the theme changes (#1015) - Add `output_only` attribute to web component (#1019 & originally #782) - Add `assets_identifier` attribute to web component (#1019 & originally #901) - Enhance `code` attribute on web component to override project main component content (#1019 & originally #901) - Add `runCode`, `stopCode` & `rerunCode` methods to web component (#1019 & originally #899) - Send error details in "editor-runCompleted" event (#1019 & originally #915) - Return error details to web component (#1019 & originally #915) - Add `output_panels` attribute to web component (#1019 & originally #909) ### Changed - Remove unused `/embedded/projects/:identifier` route (#1013) ### Fixed - Remove unused `REACT_APP_LOGIN_ENABLED` env var (#1006) - Fix infinite remix loop when `BYPASS_AUTH` set in `editor-api` (#1007) - Fixes for docker-compose.yml (#1008) - Fix deprecation warnings in GitHub Actions (#1011) - Removed unused `isEmbedded` param from `useProject` call in `EmbeddedViewer` (#1016) - Improvements to Cypress specs in CI (#1017) - Fix warnings and verbose output when starting Webpack Dev Server (#1018) - Add e2e spec for project remix behaviour in web component (#1020) - Fix initial value of `user` in `WebComponentLoader` (#1021) - Make `authKey` in e2e web component spec more realistic (#1022) - Remove unused `ComponentStore` (#1023)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit notes for more detail: