Specify code output panel(s) in web component #909

create-issue-branch · 2024-01-29T09:57:06Z

closes #906

github-actions · 2024-01-29T09:59:23Z

Github Run 7694207794
Test coverage: 85%

github-actions · 2024-01-29T09:59:27Z

Github Run 7694208159
Test coverage: 85%

…el_s_in_web_component

github-actions · 2024-01-29T12:27:20Z

Github Run 7695982011
Test coverage: 84%

github-actions · 2024-01-29T17:58:56Z

Github Run 7700361024
Test coverage: 84%

…el_s_in_web_component

github-actions · 2024-01-30T17:42:11Z

Github Run 7715224840
Test coverage: 84%

github-actions · 2024-01-31T13:07:45Z

Github Run 7726513050
Test coverage: 84%

github-actions · 2024-01-31T13:14:18Z

Github Run 7726596104
Test coverage: 84%

danhalson

Looks great, just the one suggestion that I think help make things easier to read / more manageable?

danhalson · 2024-02-01T08:04:47Z

src/components/Editor/Runners/PythonRunner/PythonRunner.jsx

-            <div className="output-panel output-panel--visual">
+          {hasVisualOutput && showVisualOutput && (
+            <div
+              className={`output-panel output-panel--visual${


the classnames package (which we're using elsewhere) offers a nice and easy to read interface for doing this, might be worth taking a look :)

Ah yes, okay, I'll take a look - thanks Dan 👍

…el_s_in_web_component

github-actions · 2024-02-01T17:00:31Z

Github Run 7744832398
Test coverage: 84%

github-actions · 2024-02-01T17:02:44Z

Github Run 7744864988
Test coverage: 84%

sra405 · 2024-02-01T17:17:28Z

src/components/Editor/Runners/PythonRunner/PythonRunner.jsx

+                  {!hasVisualOutput && !isEmbedded && isMobile ? (
+                    <RunnerControls skinny />
+                  ) : null}


⛏️ I'm sure I've tried this before but it might not work... can we get rid of this null?

Suggested change

{!hasVisualOutput && !isEmbedded && isMobile ? (

<RunnerControls skinny />

) : null}

{!hasVisualOutput && !isEmbedded && isMobile && (

<RunnerControls skinny />

)}

github-actions · 2024-02-01T17:28:26Z

Github Run 7745206493
Test coverage: 84%

sra405

👍 lgtm

Based on #909.

Based on #909. The new `output_panels` attribute on the web component allows specific panels to be selected when the `output-only` web component attribute is set to `true`. Currently there are two panels: the "text" panel and the "visual" panel. You can select either or both. Note that this functionality has only currently been implemented for the `PythonRunner` and not the `PyodideRunner` or the `HtmlRunner`. The motivation for this change is to support the Block-to-Text app [1]. The exercise in the alpha version of this app displays just the "visual" panel [2]. I've added a couple of unit tests in `PythonRunner.test.js` to test the new behaviour. And I plan to add an e2e spec in a subsequent commit which will test all the new attributes on the web component. [1]: https://github.com/RaspberryPiFoundation/block-to-text-alpha/ [2]: https://github.com/RaspberryPiFoundation/block-to-text-alpha/blob/d16a8ecc1d3da202363fb16db31f4bf93f46aa04/src/components/Editor.js#L19

### Added - Add `project_name_editable` attribute to web component (#1009) - Fires custom event when the theme changes (#1015) - Add `output_only` attribute to web component (#1019 & originally #782) - Add `assets_identifier` attribute to web component (#1019 & originally #901) - Enhance `code` attribute on web component to override project main component content (#1019 & originally #901) - Add `runCode`, `stopCode` & `rerunCode` methods to web component (#1019 & originally #899) - Send error details in "editor-runCompleted" event (#1019 & originally #915) - Return error details to web component (#1019 & originally #915) - Add `output_panels` attribute to web component (#1019 & originally #909) ### Changed - Remove unused `/embedded/projects/:identifier` route (#1013) ### Fixed - Remove unused `REACT_APP_LOGIN_ENABLED` env var (#1006) - Fix infinite remix loop when `BYPASS_AUTH` set in `editor-api` (#1007) - Fixes for docker-compose.yml (#1008) - Fix deprecation warnings in GitHub Actions (#1011) - Removed unused `isEmbedded` param from `useProject` call in `EmbeddedViewer` (#1016) - Improvements to Cypress specs in CI (#1017) - Fix warnings and verbose output when starting Webpack Dev Server (#1018) - Add e2e spec for project remix behaviour in web component (#1020) - Fix initial value of `user` in `WebComponentLoader` (#1021) - Make `authKey` in e2e web component spec more realistic (#1022) - Remove unused `ComponentStore` (#1023)

Create draft PR for #906

2628ffc

create-issue-branch bot temporarily deployed to previews/issues/906-Specify_code_output_panel_s_in_web_component January 29, 2024 09:57 Inactive

loiswells97 changed the base branch from main to output-only-wc January 29, 2024 12:24

Merge branch 'output-only-wc' into issues/906-Specify_code_output_pan…

1797c56

…el_s_in_web_component

loiswells97 temporarily deployed to previews/issues/906-Specify_code_output_panel_s_in_web_component January 29, 2024 12:25 — with GitHub Actions Inactive

specify output panels

6c0a201

loiswells97 temporarily deployed to previews/issues/906-Specify_code_output_panel_s_in_web_component January 29, 2024 17:56 — with GitHub Actions Inactive

Merge branch 'output-only-wc' into issues/906-Specify_code_output_pan…

a733d17

…el_s_in_web_component

loiswells97 temporarily deployed to previews/issues/906-Specify_code_output_panel_s_in_web_component January 30, 2024 17:40 — with GitHub Actions Inactive

fix the tabs flashing up

eb30a4b

loiswells97 temporarily deployed to previews/issues/906-Specify_code_output_panel_s_in_web_component January 31, 2024 11:03 — with GitHub Actions Inactive

removing rogue semicolon

2ba0e59

loiswells97 temporarily deployed to previews/issues/906-Specify_code_output_panel_s_in_web_component January 31, 2024 12:08 — with GitHub Actions Inactive

tabs styling fixing

19fafc7

loiswells97 temporarily deployed to previews/issues/906-Specify_code_output_panel_s_in_web_component January 31, 2024 12:34 — with GitHub Actions Inactive

better solution for the tab flash

5fbfc8e

loiswells97 temporarily deployed to previews/issues/906-Specify_code_output_panel_s_in_web_component January 31, 2024 13:05 — with GitHub Actions Inactive

tidying and changelog

be56c6d

loiswells97 temporarily deployed to previews/issues/906-Specify_code_output_panel_s_in_web_component January 31, 2024 13:11 — with GitHub Actions Inactive

loiswells97 marked this pull request as ready for review January 31, 2024 13:12

danhalson reviewed Feb 1, 2024

View reviewed changes

refactoring classnames

54b1b36

loiswells97 temporarily deployed to previews/issues/906-Specify_code_output_panel_s_in_web_component February 1, 2024 16:58 — with GitHub Actions Inactive

Merge branch 'output-only-wc' into issues/906-Specify_code_output_pan…

dee2855

…el_s_in_web_component

loiswells97 temporarily deployed to previews/issues/906-Specify_code_output_panel_s_in_web_component February 1, 2024 17:00 — with GitHub Actions Inactive

sra405 reviewed Feb 1, 2024

View reviewed changes

removing some nulls

4db9b06

loiswells97 deployed to previews/issues/906-Specify_code_output_panel_s_in_web_component February 1, 2024 17:26 — with GitHub Actions View deployment

sra405 approved these changes Feb 1, 2024

View reviewed changes

loiswells97 merged commit c6d568b into output-only-wc Feb 2, 2024

loiswells97 deleted the issues/906-Specify_code_output_panel_s_in_web_component branch February 2, 2024 09:14

floehopper pushed a commit that referenced this pull request May 20, 2024

Specify code output panel(s) in web component

262bd2e

Based on #909.

floehopper pushed a commit that referenced this pull request May 20, 2024

Specify code output panel(s) in web component

5276d1a

Based on #909.

floehopper pushed a commit that referenced this pull request May 20, 2024

Specify code output panels in web component

c39fe2a

Based on #909.

floehopper pushed a commit that referenced this pull request May 20, 2024

Specify code output panels in web component

7a3f113

Based on #909.

floehopper pushed a commit that referenced this pull request May 22, 2024

Specify code output panels in web component

51117dc

Based on #909.

floehopper pushed a commit that referenced this pull request May 22, 2024

Specify code output panels in web component

2ff76c0

Based on #909.

floehopper pushed a commit that referenced this pull request May 28, 2024

Specify code output panels in web component

8a3ccd1

Based on #909.

floehopper pushed a commit that referenced this pull request May 29, 2024

Specify code output panels in web component

d555f03

Based on #909.

floehopper pushed a commit that referenced this pull request May 30, 2024

Specify code output panels in web component

53e5c49

Based on #909.

floehopper pushed a commit that referenced this pull request May 30, 2024

Specify code output panels in web component

58da5f1

Based on #909.

floehopper pushed a commit that referenced this pull request May 30, 2024

Specify code output panels in web component

4afd62f

Based on #909.

floehopper pushed a commit that referenced this pull request May 30, 2024

Specify code output panels in web component

0a5ebf6

Based on #909.

floehopper mentioned this pull request Jun 3, 2024

Release v0.24.0 #1028

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Specify code output panel(s) in web component #909

Specify code output panel(s) in web component #909

Uh oh!

create-issue-branch bot commented Jan 29, 2024

Uh oh!

github-actions bot commented Jan 29, 2024

Uh oh!

github-actions bot commented Jan 29, 2024

Uh oh!

github-actions bot commented Jan 29, 2024

Uh oh!

github-actions bot commented Jan 29, 2024

Uh oh!

github-actions bot commented Jan 30, 2024

Uh oh!

github-actions bot commented Jan 31, 2024

Uh oh!

github-actions bot commented Jan 31, 2024

Uh oh!

danhalson left a comment

Uh oh!

danhalson Feb 1, 2024

Uh oh!

loiswells97 Feb 1, 2024

Uh oh!

github-actions bot commented Feb 1, 2024

Uh oh!

github-actions bot commented Feb 1, 2024

Uh oh!

sra405 Feb 1, 2024

Uh oh!

github-actions bot commented Feb 1, 2024

Uh oh!

sra405 left a comment

Uh oh!

Uh oh!

Specify code output panel(s) in web component #909

Specify code output panel(s) in web component #909

Uh oh!

Conversation

create-issue-branch bot commented Jan 29, 2024

Uh oh!

github-actions bot commented Jan 29, 2024

Uh oh!

github-actions bot commented Jan 29, 2024

Uh oh!

github-actions bot commented Jan 29, 2024

Uh oh!

github-actions bot commented Jan 29, 2024

Uh oh!

github-actions bot commented Jan 30, 2024

Uh oh!

github-actions bot commented Jan 31, 2024

Uh oh!

github-actions bot commented Jan 31, 2024

Uh oh!

danhalson left a comment

Choose a reason for hiding this comment

Uh oh!

danhalson Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

loiswells97 Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 1, 2024

Uh oh!

github-actions bot commented Feb 1, 2024

Uh oh!

sra405 Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 1, 2024

Uh oh!

sra405 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!