perf(linter): only run rule run functions if implemented #14454

camchenry · 2025-10-09T01:43:41Z

Optimizes the native linter runtime by skipping rule run functions which are known to be no-ops. If we don't know anything about the rule functions implemented, we run all of them by default.

camchenry · 2025-10-09T01:43:55Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-10-09T01:52:28Z

CodSpeed Performance Report

Merging #14454 will improve performances by 14.72%

_{Comparing 10-08-perf_linter_only_run_rule_run_functions_if_implemented (422f54e) with main (9e9c5ba)¹}

Summary

⚡ 4 improvements
⏩ 33 skipped²

Benchmarks breakdown

	Mode	Benchmark	`BASE`	`HEAD`	Change
⚡	Instrumentation	`linter[RadixUIAdoptionSection.jsx]`	1.6 ms	1.4 ms	+14.9%
⚡	Instrumentation	`linter[binder.ts]`	87.8 ms	74.3 ms	+18.28%
⚡	Instrumentation	`linter[cal.com.tsx]`	724 ms	631.1 ms	+14.72%
⚡	Instrumentation	`linter[react.development.js]`	32.7 ms	27.7 ms	+17.86%

No successful run was found on main (422f54e) during the generation of this report, so 9e9c5ba was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

camchenry · 2025-10-09T01:55:47Z

Not sure what this translates into in the real-world at the moment, but benchmarks look good!

camc314

🚀 🚀 🚀

graphite-app · 2025-10-12T10:22:16Z

Merge activity

Oct 12, 10:22 AM UTC: camc314 added this pull request to the Graphite merge queue.
Oct 12, 10:57 AM UTC: The Graphite merge queue couldn't merge this PR because it timed out.
Oct 12, 11:40 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 13, 11:43 AM UTC: camc314 added this pull request to the Graphite merge queue.
Oct 13, 11:53 AM UTC: Merged by the Graphite merge queue.

Optimizes the native linter runtime by skipping rule run functions which are known to be no-ops. If we don't know anything about the rule functions implemented, we run all of them by default.

Copilot

Pull Request Overview

This PR optimizes the native linter runtime by adding conditional execution of rule run functions based on whether they are actually implemented, avoiding unnecessary function calls for no-op rules.

Added helper methods to check if specific rule run functions are implemented
Modified linter execution to conditionally call rule functions only when they contain actual implementations
Renamed the optimization flag from with_ast_kind_filtering to with_runtime_optimization to better reflect its expanded purpose

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_linter/src/rule.rs	Added helper methods to check if specific rule run functions are implemented
crates/oxc_linter/src/lib.rs	Modified linter execution logic to conditionally call rule functions based on implementation status

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/lib.rs

Optimizes the native linter runtime by skipping rule run functions which are known to be no-ops. If we don't know anything about the rule functions implemented, we run all of them by default.

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_linter/src/lib.rs

Optimizes the native linter runtime by skipping rule run functions which are known to be no-ops. If we don't know anything about the rule functions implemented, we run all of them by default.

## [1.23.0] - 2025-10-13 ### 🚀 Features - 452d128 linter: Node/no_process_env (#14536) (Kenneth Skovhus) - a9e1261 linter: Implement react-refresh/only-export-components (#14122) (Rintaro Itokawa) - a8d542b linter/no-duplicate-imports: Support `allowSeparateTypeImports` option (#14527) (camc314) - 75a529c linter: Add run info about what functions rules implement (#13839) (camchenry) - 4fbdef2 language_server: Support `fmt.configPath` configuration (#14502) (Sysix) - 4d3ce2e language_server: Autodetect root `.oxfmtrc.json` (#14466) (Sysix) ### 🐛 Bug Fixes - fb4a20d language_server: Add whitespace for `// oxlint-disable-next-line` fix (#14356) (Sysix) - 6fce7f4 oxlint/changelog: Remove duplicate changelog entries (#14528) (camc314) - 74e52f3 linter/plugins: Resolve JS plugins with ESM condition names (#14541) (magic-akari) - 9965676 linter/exhaustive-deps: Ignore empty strings passed to `additionalHooks` option (#14464) (Redas) - d0a8e3e linter: `vue/no_required_prop_with_default` called `Option::unwrap()` on a `None` value (#14491) (Sysix) - 1192ea2 linter: Correct `nextjs/no-typos` path handling (#14480) (shulaoda) - 2796b16 tsgolint: Pipe tsgolints stderr (#14477) (camc314) ### 🚜 Refactor - 6440cde linter: Remove lifetime of `Message` (#14481) (Sysix) - f599bef language_server: Move `Message` to `DiagnosticReport` transformation to one place (#14447) (Sysix) - 4f301de napi/parser, linter/plugins: Improve formatting of generated code (#14554) (overlookmotel) - 68c0252 napi/parser, linter/plugins: Shorten generated raw transfer deserializer code (#14553) (overlookmotel) - 20e884e linter: Store `LintService` in `LintRunner` (#14471) (Sysix) - 9e9c5ba linter: Simplify built-in lint plugin checks (#14518) (camchenry) - 1986e0f linter/no-ex-assign: Use let-else chain (#14526) (camc314) - ce9bcf0 linter/no-func-assign: Use let-else chain (#14525) (camc314) - a9cea7c language_server: Use `FxHashSet` for `ServerLinter::extended_paths` (#14517) (Sysix) - ea5838e linter/no-import-assign: Use let-else chain (#14524) (camc314) - f977700 language_server: Pass `LintOptions` to `Worker::refresh_server_linter` (#14510) (Sysix) - 54b001f linter/no-new-require: Improve diagnostic message clarity (#14511) (shulaoda) - 650ea68 linter: Improve nextjs/no-typos rule (#14476) (shulaoda) ### 📚 Documentation - 198f2e9 linter: Fix code example for `branches-sharing-code` (#14514) (camc314) - d776a17 linter: Improve `nextjs/no-typos` rule documentation (#14470) (shulaoda) ### ⚡ Performance - b44a30e language_server: Transform `Message` to `DiagnosticReport` with one call (#14448) (Sysix) - 31766fd linter/plugins: Provide `loc` via prototype (#14552) (overlookmotel) - aec0c08 linter: Allow analyzing node types in match blocks with guards (#14459) (camchenry) - 9044187 linter: Skip running node-specific rule if file contains no relevant nodes (#14457) (camchenry) - 422f54e linter: Only run rule run functions if implemented (#14454) (camchenry) - 2c228ae liner: Use top-level match for `no_obj_calls` (#14523) (camchenry) - c49d891 linter: Use match for `no_negated_condition` (#14522) (camchenry) - e222fc2 linter: Use match for `no_multi_assign` (#14521) (camchenry) - 4440516 linter: Refactor rules to take advantage of node type skipping (#14519) (camchenry) - 78261d6 linter: Refactor `no-invalid-fetch-options` to be more easily analyzed (#14458) (camchenry) ### 🧪 Testing - 8d8881d linter/plugins: Expand tests for module resolution of plugins (#14559) (overlookmotel) - 33b6cde language_server: Add basic tests for `WorkspaceWorker::did_change_configuration` (#14531) (Sysix) - bfe1ecd language_server: Add tests for `WorkspaceWorker::init_watchers` (#14516) (Sysix) Co-authored-by: camc314 <[email protected]>

camchenry mentioned this pull request Oct 9, 2025

feat(linter): add run info about what functions rules implement #13839

Merged

github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 9, 2025

camchenry force-pushed the 10-08-perf_linter_only_run_rule_run_functions_if_implemented branch from baac6b9 to cd59e8a Compare October 9, 2025 01:46

camchenry force-pushed the 10-08-perf_linter_only_run_rule_run_functions_if_implemented branch from cd59e8a to 69a5622 Compare October 9, 2025 01:54

camchenry marked this pull request as ready for review October 9, 2025 01:57

camchenry requested a review from camc314 as a code owner October 9, 2025 01:57

camchenry force-pushed the 10-08-perf_linter_only_run_rule_run_functions_if_implemented branch from 69a5622 to b253964 Compare October 9, 2025 02:24

camchenry force-pushed the 09-16-perf_linter_filter_out_rules_with_no_applicable_run_implementations branch from b396106 to 36c2471 Compare October 9, 2025 02:24

This was referenced Oct 9, 2025

perf(linter): skip running node-specific rule if file contains no relevant nodes #14457

Merged

perf(linter): allow analyzing node types in match blocks with guards #14459

Merged

camchenry force-pushed the 09-16-perf_linter_filter_out_rules_with_no_applicable_run_implementations branch from 36c2471 to b19a73d Compare October 11, 2025 23:55

camchenry force-pushed the 10-08-perf_linter_only_run_rule_run_functions_if_implemented branch from b253964 to 2dd6c2c Compare October 11, 2025 23:55

camc314 changed the base branch from 09-16-perf_linter_filter_out_rules_with_no_applicable_run_implementations to graphite-base/14454 October 12, 2025 10:16

camc314 approved these changes Oct 12, 2025

View reviewed changes

graphite-app bot force-pushed the 10-08-perf_linter_only_run_rule_run_functions_if_implemented branch from 2dd6c2c to d21833b Compare October 12, 2025 10:23

graphite-app bot requested a review from Sysix as a code owner October 12, 2025 10:23

github-actions bot added the A-editor Area - Editor and Language Server label Oct 12, 2025

graphite-app bot changed the base branch from graphite-base/14454 to 09-16-perf_linter_filter_out_rules_with_no_applicable_run_implementations October 12, 2025 10:23

Base automatically changed from 09-16-perf_linter_filter_out_rules_with_no_applicable_run_implementations to main October 12, 2025 10:27

camc314 self-assigned this Oct 12, 2025

camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 12, 2025

Copilot AI review requested due to automatic review settings October 12, 2025 11:46

camc314 force-pushed the 10-08-perf_linter_only_run_rule_run_functions_if_implemented branch from d21833b to 4820038 Compare October 12, 2025 11:46

Copilot AI reviewed Oct 12, 2025

View reviewed changes

crates/oxc_linter/src/lib.rs Outdated Show resolved Hide resolved

camc314 force-pushed the 10-08-perf_linter_only_run_rule_run_functions_if_implemented branch from 4820038 to 8cc4f98 Compare October 13, 2025 11:44

camc314 requested a review from Copilot October 13, 2025 11:44

Copilot AI reviewed Oct 13, 2025

View reviewed changes

crates/oxc_linter/src/lib.rs Show resolved Hide resolved

crates/oxc_linter/src/lib.rs Show resolved Hide resolved

crates/oxc_linter/src/lib.rs Show resolved Hide resolved

graphite-app bot force-pushed the 10-08-perf_linter_only_run_rule_run_functions_if_implemented branch from 8cc4f98 to a0bfd0b Compare October 13, 2025 11:48

perf(linter): only run rule run functions if implemented (#14454)

422f54e

Optimizes the native linter runtime by skipping rule run functions which are known to be no-ops. If we don't know anything about the rule functions implemented, we run all of them by default.

camc314 force-pushed the 10-08-perf_linter_only_run_rule_run_functions_if_implemented branch from a0bfd0b to 422f54e Compare October 13, 2025 11:49

graphite-app bot merged commit 422f54e into main Oct 13, 2025
20 checks passed

graphite-app bot deleted the 10-08-perf_linter_only_run_rule_run_functions_if_implemented branch October 13, 2025 11:53

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 13, 2025

Boshen mentioned this pull request Oct 13, 2025

release(oxlint): v1.23.0 #14560

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

perf(linter): only run rule run functions if implemented #14454

perf(linter): only run rule run functions if implemented #14454

Uh oh!

camchenry commented Oct 9, 2025 •

edited

Loading

Uh oh!

camchenry commented Oct 9, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 9, 2025 •

edited

Loading

Uh oh!

camchenry commented Oct 9, 2025

Uh oh!

camc314 left a comment

Uh oh!

graphite-app bot commented Oct 12, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

perf(linter): only run rule run functions if implemented #14454

perf(linter): only run rule run functions if implemented #14454

Uh oh!

Conversation

camchenry commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camchenry commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #14454 will improve performances by 14.72%

Summary

Benchmarks breakdown

Footnotes

Uh oh!

camchenry commented Oct 9, 2025

Uh oh!

camc314 left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

camchenry commented Oct 9, 2025 •

edited

Loading

camchenry commented Oct 9, 2025 •

edited

Loading

codspeed-hq bot commented Oct 9, 2025 •

edited

Loading

graphite-app bot commented Oct 12, 2025 •

edited

Loading