test(language_server): add tests for `WorkspaceWorker::init_watchers` #14516

Sysix · 2025-10-11T21:26:59Z

Working on the watcher for .oxfmtrc.json, so some tests would be not wrong ;)

Sysix · 2025-10-11T21:27:18Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR adds comprehensive test coverage for the WorkspaceWorker::init_watchers method in the language server. The tests verify that file system watchers are correctly configured for different linter configuration scenarios.

Adds a test module with helper struct Tester to simplify testing workspace worker functionality
Creates test fixtures for different watcher scenarios (default and linter extends configurations)
Implements four test cases covering default options, custom config paths, and extended configurations

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
crates/oxc_language_server/src/worker.rs	Adds comprehensive test module for `init_watchers` method with helper struct and four test cases
crates/oxc_language_server/fixtures/watcher/linter_extends/lint.json	Test fixture providing empty JSON config for extends testing
crates/oxc_language_server/fixtures/watcher/linter_extends/.oxlintrc.json	Test fixture with extends configuration pointing to lint.json
crates/oxc_language_server/fixtures/watcher/default/.oxlintrc.json	Test fixture providing basic empty configuration for default testing

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_language_server/src/worker.rs

camc314 · 2025-10-12T11:19:41Z

Merge activity

Oct 12, 11:19 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 12, 11:19 AM UTC: camc314 added this pull request to the Graphite merge queue.
Oct 12, 11:24 AM UTC: Merged by the Graphite merge queue.

…#14516) Working on the watcher for `.oxfmtrc.json`, so some tests would be not wrong ;)

…d_paths` (#14517) Fixes duplicate entries in `extended_paths`, found by the tests in #14516.

## [1.23.0] - 2025-10-13 ### 🚀 Features - 452d128 linter: Node/no_process_env (#14536) (Kenneth Skovhus) - a9e1261 linter: Implement react-refresh/only-export-components (#14122) (Rintaro Itokawa) - a8d542b linter/no-duplicate-imports: Support `allowSeparateTypeImports` option (#14527) (camc314) - 75a529c linter: Add run info about what functions rules implement (#13839) (camchenry) - 4fbdef2 language_server: Support `fmt.configPath` configuration (#14502) (Sysix) - 4d3ce2e language_server: Autodetect root `.oxfmtrc.json` (#14466) (Sysix) ### 🐛 Bug Fixes - fb4a20d language_server: Add whitespace for `// oxlint-disable-next-line` fix (#14356) (Sysix) - 6fce7f4 oxlint/changelog: Remove duplicate changelog entries (#14528) (camc314) - 74e52f3 linter/plugins: Resolve JS plugins with ESM condition names (#14541) (magic-akari) - 9965676 linter/exhaustive-deps: Ignore empty strings passed to `additionalHooks` option (#14464) (Redas) - d0a8e3e linter: `vue/no_required_prop_with_default` called `Option::unwrap()` on a `None` value (#14491) (Sysix) - 1192ea2 linter: Correct `nextjs/no-typos` path handling (#14480) (shulaoda) - 2796b16 tsgolint: Pipe tsgolints stderr (#14477) (camc314) ### 🚜 Refactor - 6440cde linter: Remove lifetime of `Message` (#14481) (Sysix) - f599bef language_server: Move `Message` to `DiagnosticReport` transformation to one place (#14447) (Sysix) - 4f301de napi/parser, linter/plugins: Improve formatting of generated code (#14554) (overlookmotel) - 68c0252 napi/parser, linter/plugins: Shorten generated raw transfer deserializer code (#14553) (overlookmotel) - 20e884e linter: Store `LintService` in `LintRunner` (#14471) (Sysix) - 9e9c5ba linter: Simplify built-in lint plugin checks (#14518) (camchenry) - 1986e0f linter/no-ex-assign: Use let-else chain (#14526) (camc314) - ce9bcf0 linter/no-func-assign: Use let-else chain (#14525) (camc314) - a9cea7c language_server: Use `FxHashSet` for `ServerLinter::extended_paths` (#14517) (Sysix) - ea5838e linter/no-import-assign: Use let-else chain (#14524) (camc314) - f977700 language_server: Pass `LintOptions` to `Worker::refresh_server_linter` (#14510) (Sysix) - 54b001f linter/no-new-require: Improve diagnostic message clarity (#14511) (shulaoda) - 650ea68 linter: Improve nextjs/no-typos rule (#14476) (shulaoda) ### 📚 Documentation - 198f2e9 linter: Fix code example for `branches-sharing-code` (#14514) (camc314) - d776a17 linter: Improve `nextjs/no-typos` rule documentation (#14470) (shulaoda) ### ⚡ Performance - b44a30e language_server: Transform `Message` to `DiagnosticReport` with one call (#14448) (Sysix) - 31766fd linter/plugins: Provide `loc` via prototype (#14552) (overlookmotel) - aec0c08 linter: Allow analyzing node types in match blocks with guards (#14459) (camchenry) - 9044187 linter: Skip running node-specific rule if file contains no relevant nodes (#14457) (camchenry) - 422f54e linter: Only run rule run functions if implemented (#14454) (camchenry) - 2c228ae liner: Use top-level match for `no_obj_calls` (#14523) (camchenry) - c49d891 linter: Use match for `no_negated_condition` (#14522) (camchenry) - e222fc2 linter: Use match for `no_multi_assign` (#14521) (camchenry) - 4440516 linter: Refactor rules to take advantage of node type skipping (#14519) (camchenry) - 78261d6 linter: Refactor `no-invalid-fetch-options` to be more easily analyzed (#14458) (camchenry) ### 🧪 Testing - 8d8881d linter/plugins: Expand tests for module resolution of plugins (#14559) (overlookmotel) - 33b6cde language_server: Add basic tests for `WorkspaceWorker::did_change_configuration` (#14531) (Sysix) - bfe1ecd language_server: Add tests for `WorkspaceWorker::init_watchers` (#14516) (Sysix) Co-authored-by: camc314 <[email protected]>

github-actions bot added A-editor Area - Editor and Language Server C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Oct 11, 2025

Sysix force-pushed the 10-11-test_language_server_add_tests_for_workspaceworker_init_watchers_ branch 2 times, most recently from 3af53a2 to d0110c4 Compare October 11, 2025 21:35

Sysix mentioned this pull request Oct 11, 2025

refactor(language_server): use FxHashSet for ServerLinter::extended_paths #14517

Merged

Sysix requested a review from Copilot October 11, 2025 22:04

Copilot AI reviewed Oct 11, 2025

View reviewed changes

crates/oxc_language_server/src/worker.rs Show resolved Hide resolved

crates/oxc_language_server/src/worker.rs Show resolved Hide resolved

Sysix marked this pull request as ready for review October 11, 2025 22:07

Sysix requested a review from camc314 as a code owner October 11, 2025 22:07

camc314 approved these changes Oct 12, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 12, 2025

test(language_server): add tests for WorkspaceWorker::init_watchers (…

bfe1ecd

…#14516) Working on the watcher for `.oxfmtrc.json`, so some tests would be not wrong ;)

graphite-app bot force-pushed the 10-11-test_language_server_add_tests_for_workspaceworker_init_watchers_ branch from d0110c4 to bfe1ecd Compare October 12, 2025 11:20

graphite-app bot pushed a commit that referenced this pull request Oct 12, 2025

refactor(language_server): use FxHashSet for `ServerLinter::extende…

a9cea7c

…d_paths` (#14517) Fixes duplicate entries in `extended_paths`, found by the tests in #14516.

graphite-app bot merged commit bfe1ecd into main Oct 12, 2025
21 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 12, 2025

graphite-app bot deleted the 10-11-test_language_server_add_tests_for_workspaceworker_init_watchers_ branch October 12, 2025 11:24

Boshen mentioned this pull request Oct 13, 2025

release(oxlint): v1.23.0 #14560

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test(language_server): add tests for `WorkspaceWorker::init_watchers` #14516

test(language_server): add tests for `WorkspaceWorker::init_watchers` #14516

Sysix commented Oct 11, 2025 •

edited

Loading

Uh oh!

Sysix commented Oct 11, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

camc314 commented Oct 12, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

test(language_server): add tests for WorkspaceWorker::init_watchers #14516

test(language_server): add tests for WorkspaceWorker::init_watchers #14516

Conversation

Sysix commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Oct 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

camc314 commented Oct 12, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

test(language_server): add tests for `WorkspaceWorker::init_watchers` #14516

test(language_server): add tests for `WorkspaceWorker::init_watchers` #14516

Sysix commented Oct 11, 2025 •

edited

Loading

Sysix commented Oct 11, 2025 •

edited

Loading

camc314 commented Oct 12, 2025 •

edited by graphite-app bot

Loading