refactor(linter/no-ex-assign): use let-else chain #14526

camc314 · 2025-10-12T10:07:44Z

No description provided.

camc314 · 2025-10-12T10:08:04Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

graphite-app · 2025-10-12T10:11:12Z

Merge activity

Oct 12, 10:11 AM UTC: camc314 added this pull request to the Graphite merge queue.
Oct 12, 10:16 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #14524.
Oct 12, 10:16 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #14524.
Oct 12, 11:20 AM UTC: camc314 added this pull request to the Graphite merge queue.
Oct 12, 11:29 AM UTC: Merged by the Graphite merge queue.

codspeed-hq · 2025-10-12T10:12:52Z

CodSpeed Performance Report

Merging #14526 will not alter performance

_{Comparing c/10-12-refactor_linter_no-ex-assign_use_let-else_chain (1986e0f) with main (ea5838e)¹}

Summary

✅ 4 untouched
⏩ 33 skipped²

No successful run was found on main (1986e0f) during the generation of this report, so ea5838e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

## [1.23.0] - 2025-10-13 ### 🚀 Features - 452d128 linter: Node/no_process_env (#14536) (Kenneth Skovhus) - a9e1261 linter: Implement react-refresh/only-export-components (#14122) (Rintaro Itokawa) - a8d542b linter/no-duplicate-imports: Support `allowSeparateTypeImports` option (#14527) (camc314) - 75a529c linter: Add run info about what functions rules implement (#13839) (camchenry) - 4fbdef2 language_server: Support `fmt.configPath` configuration (#14502) (Sysix) - 4d3ce2e language_server: Autodetect root `.oxfmtrc.json` (#14466) (Sysix) ### 🐛 Bug Fixes - fb4a20d language_server: Add whitespace for `// oxlint-disable-next-line` fix (#14356) (Sysix) - 6fce7f4 oxlint/changelog: Remove duplicate changelog entries (#14528) (camc314) - 74e52f3 linter/plugins: Resolve JS plugins with ESM condition names (#14541) (magic-akari) - 9965676 linter/exhaustive-deps: Ignore empty strings passed to `additionalHooks` option (#14464) (Redas) - d0a8e3e linter: `vue/no_required_prop_with_default` called `Option::unwrap()` on a `None` value (#14491) (Sysix) - 1192ea2 linter: Correct `nextjs/no-typos` path handling (#14480) (shulaoda) - 2796b16 tsgolint: Pipe tsgolints stderr (#14477) (camc314) ### 🚜 Refactor - 6440cde linter: Remove lifetime of `Message` (#14481) (Sysix) - f599bef language_server: Move `Message` to `DiagnosticReport` transformation to one place (#14447) (Sysix) - 4f301de napi/parser, linter/plugins: Improve formatting of generated code (#14554) (overlookmotel) - 68c0252 napi/parser, linter/plugins: Shorten generated raw transfer deserializer code (#14553) (overlookmotel) - 20e884e linter: Store `LintService` in `LintRunner` (#14471) (Sysix) - 9e9c5ba linter: Simplify built-in lint plugin checks (#14518) (camchenry) - 1986e0f linter/no-ex-assign: Use let-else chain (#14526) (camc314) - ce9bcf0 linter/no-func-assign: Use let-else chain (#14525) (camc314) - a9cea7c language_server: Use `FxHashSet` for `ServerLinter::extended_paths` (#14517) (Sysix) - ea5838e linter/no-import-assign: Use let-else chain (#14524) (camc314) - f977700 language_server: Pass `LintOptions` to `Worker::refresh_server_linter` (#14510) (Sysix) - 54b001f linter/no-new-require: Improve diagnostic message clarity (#14511) (shulaoda) - 650ea68 linter: Improve nextjs/no-typos rule (#14476) (shulaoda) ### 📚 Documentation - 198f2e9 linter: Fix code example for `branches-sharing-code` (#14514) (camc314) - d776a17 linter: Improve `nextjs/no-typos` rule documentation (#14470) (shulaoda) ### ⚡ Performance - b44a30e language_server: Transform `Message` to `DiagnosticReport` with one call (#14448) (Sysix) - 31766fd linter/plugins: Provide `loc` via prototype (#14552) (overlookmotel) - aec0c08 linter: Allow analyzing node types in match blocks with guards (#14459) (camchenry) - 9044187 linter: Skip running node-specific rule if file contains no relevant nodes (#14457) (camchenry) - 422f54e linter: Only run rule run functions if implemented (#14454) (camchenry) - 2c228ae liner: Use top-level match for `no_obj_calls` (#14523) (camchenry) - c49d891 linter: Use match for `no_negated_condition` (#14522) (camchenry) - e222fc2 linter: Use match for `no_multi_assign` (#14521) (camchenry) - 4440516 linter: Refactor rules to take advantage of node type skipping (#14519) (camchenry) - 78261d6 linter: Refactor `no-invalid-fetch-options` to be more easily analyzed (#14458) (camchenry) ### 🧪 Testing - 8d8881d linter/plugins: Expand tests for module resolution of plugins (#14559) (overlookmotel) - 33b6cde language_server: Add basic tests for `WorkspaceWorker::did_change_configuration` (#14531) (Sysix) - bfe1ecd language_server: Add tests for `WorkspaceWorker::init_watchers` (#14516) (Sysix) Co-authored-by: camc314 <[email protected]>

camchenry mentioned this pull request Oct 12, 2025

perf(linter): refactor rules to take advantage of node type skipping #14519

Merged

github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Oct 12, 2025

camc314 marked this pull request as ready for review October 12, 2025 10:07

This was referenced Oct 12, 2025

perf(linter): use match for no_negated_condition #14522

Merged

perf(linter): use match for no_multi_assign #14521

Merged

perf(liner): use top-level match for no_obj_calls #14523

Merged

refactor(linter/no-import-assign): use let-else chain #14524

Merged

camc314 mentioned this pull request Oct 12, 2025

refactor(linter/no-func-assign): use let-else chain #14525

Merged

camc314 force-pushed the c/10-12-refactor_linter_no-ex-assign_use_let-else_chain branch from 88affc0 to e1eacf7 Compare October 12, 2025 10:20

camc314 force-pushed the c/10-12-refactor_linter_no-func-assign_use_let-else_chain branch from ad153ee to ce250e0 Compare October 12, 2025 10:20

graphite-app bot force-pushed the c/10-12-refactor_linter_no-func-assign_use_let-else_chain branch 2 times, most recently from 0c79381 to c1d4cbe Compare October 12, 2025 11:03

camchenry approved these changes Oct 12, 2025

View reviewed changes

refactor(linter/no-ex-assign): use let-else chain (#14526)

1986e0f

graphite-app bot force-pushed the c/10-12-refactor_linter_no-func-assign_use_let-else_chain branch from c1d4cbe to ce9bcf0 Compare October 12, 2025 11:26

graphite-app bot force-pushed the c/10-12-refactor_linter_no-ex-assign_use_let-else_chain branch from e1eacf7 to 1986e0f Compare October 12, 2025 11:26

Base automatically changed from c/10-12-refactor_linter_no-func-assign_use_let-else_chain to main October 12, 2025 11:29

graphite-app bot merged commit 1986e0f into main Oct 12, 2025
21 checks passed

graphite-app bot deleted the c/10-12-refactor_linter_no-ex-assign_use_let-else_chain branch October 12, 2025 11:29

Boshen mentioned this pull request Oct 13, 2025

release(oxlint): v1.23.0 #14560

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(linter/no-ex-assign): use let-else chain #14526

refactor(linter/no-ex-assign): use let-else chain #14526

Uh oh!

camc314 commented Oct 12, 2025

Uh oh!

camc314 commented Oct 12, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 12, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

refactor(linter/no-ex-assign): use let-else chain #14526

refactor(linter/no-ex-assign): use let-else chain #14526

Uh oh!

Conversation

camc314 commented Oct 12, 2025

Uh oh!

camc314 commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

graphite-app bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

codspeed-hq bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #14526 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented Oct 12, 2025 •

edited

Loading

graphite-app bot commented Oct 12, 2025 •

edited

Loading

codspeed-hq bot commented Oct 12, 2025 •

edited

Loading