Skip to content

Fixes #12108 : Ridge regression #12108 #12257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
  • Loading branch information
pre-commit-ci[bot] committed Oct 23, 2024
commit 2eeb450e2d4c2e1f0ffb811626db32077055f3da
37 changes: 19 additions & 18 deletions machine_learning/ridge_regression/model.py
Original file line number Diff line number Diff line change
@@ -1,33 +1,37 @@
import numpy as np

Check failure on line 1 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (INP001)

machine_learning/ridge_regression/model.py:1:1: INP001 File `machine_learning/ridge_regression/model.py` is part of an implicit namespace package. Add an `__init__.py`.
import pandas as pd


class RidgeRegression:
def __init__(self, alpha:float=0.001, regularization_param:float=0.1, num_iterations:int=1000) -> None:
self.alpha:float = alpha
self.regularization_param:float = regularization_param
self.num_iterations:int = num_iterations
self.theta:np.ndarray = None


def feature_scaling(self, X:np.ndarray) -> tuple[np.ndarray, np.ndarray, np.ndarray]:
def __init__(
self,
alpha: float = 0.001,
regularization_param: float = 0.1,
num_iterations: int = 1000,
) -> None:
self.alpha: float = alpha
self.regularization_param: float = regularization_param
self.num_iterations: int = num_iterations
self.theta: np.ndarray = None

def feature_scaling(
self, X: np.ndarray

Check failure on line 18 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N803)

machine_learning/ridge_regression/model.py:18:15: N803 Argument name `X` should be lowercase
) -> tuple[np.ndarray, np.ndarray, np.ndarray]:
mean = np.mean(X, axis=0)
std = np.std(X, axis=0)

# avoid division by zero for constant features (std = 0)
std[std == 0] = 1 # set std=1 for constant features to avoid NaN

X_scaled = (X - mean) / std

Check failure on line 26 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N806)

machine_learning/ridge_regression/model.py:26:9: N806 Variable `X_scaled` in function should be lowercase
return X_scaled, mean, std


def fit(self, X:np.ndarray, y:np.ndarray) -> None:
def fit(self, X: np.ndarray, y: np.ndarray) -> None:

Check failure on line 29 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N803)

machine_learning/ridge_regression/model.py:29:19: N803 Argument name `X` should be lowercase
X_scaled, mean, std = self.feature_scaling(X)

Check failure on line 30 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N806)

machine_learning/ridge_regression/model.py:30:9: N806 Variable `X_scaled` in function should be lowercase
m, n = X_scaled.shape
self.theta = np.zeros(n) # initializing weights to zeros


for i in range(self.num_iterations):

Check failure on line 34 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (B007)

machine_learning/ridge_regression/model.py:34:13: B007 Loop control variable `i` not used within loop body
predictions = X_scaled.dot(self.theta)
error = predictions - y

Expand All @@ -37,14 +41,12 @@
) / m
self.theta -= self.alpha * gradient # updating weights


def predict(self, X:np.ndarray) -> np.ndarray:
def predict(self, X: np.ndarray) -> np.ndarray:

Check failure on line 44 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N803)

machine_learning/ridge_regression/model.py:44:23: N803 Argument name `X` should be lowercase
X_scaled, _, _ = self.feature_scaling(X)

Check failure on line 45 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N806)

machine_learning/ridge_regression/model.py:45:9: N806 Variable `X_scaled` in function should be lowercase
return X_scaled.dot(self.theta)


def compute_cost(self, X:np.ndarray, y:np.ndarray) -> float:
def compute_cost(self, X: np.ndarray, y: np.ndarray) -> float:

Check failure on line 48 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N803)

machine_learning/ridge_regression/model.py:48:28: N803 Argument name `X` should be lowercase
X_scaled, _, _ = self.feature_scaling(X)

Check failure on line 49 in machine_learning/ridge_regression/model.py

View workflow job for this annotation

GitHub Actions / ruff

Ruff (N806)

machine_learning/ridge_regression/model.py:49:9: N806 Variable `X_scaled` in function should be lowercase
m = len(y)

predictions = X_scaled.dot(self.theta)
Expand All @@ -53,8 +55,7 @@
) * np.sum(self.theta**2)
return cost


def mean_absolute_error(self, y_true:np.ndarray, y_pred:np.ndarray) -> float:
def mean_absolute_error(self, y_true: np.ndarray, y_pred: np.ndarray) -> float:
return np.mean(np.abs(y_true - y_pred))


Expand All @@ -66,7 +67,7 @@
y = (y - np.mean(y)) / np.std(y)

# added bias term to the feature matrix
X = np.c_[np.ones(X.shape[0]), X]
X = np.c_[np.ones(X.shape[0]), X]

# initialize and train the ridge regression model
model = RidgeRegression(alpha=0.01, regularization_param=0.1, num_iterations=1000)
Expand Down