Hi Stas,
On Tue, Mar 18, 2014 at 6:44 AM, Andrey Andreev <[email protected]> wrote:
> On Mon, Mar 17, 2014 at 11:35 PM, Yasuo Ohgaki <[email protected]> wrote:
> > Hi all,
> >
> > Since create_sid() method is added in 5.5.1 and it's not documented yet.
> > I would like to propose renaming it to createSid() for both 5.5 and 5.6.
> >
> > Any comments?
>
> I also thought about this, but I'm kind of split ... some users
> (besides Leigh here) might've found it and be currently using it
> regardless. And now that I know create_sid() exists, I'll surely use
> it too in pre-5.6 apps. I guess it won't hurt to still look for it if
> createSid() (or maybe even createId(), it's in the context of sessions
> after all) doesn't exist.
What do you think about this?
It could be made both create_sid() and createSid() available in 5.5 and
remove create_sid() in 5.6.
Simple renaming is cleaner and may be acceptable, since it's undocumented
and relatively new feature. I'm not sure if it is good to have more complex
code
for undocumented feature.
Regards,
--
Yasuo Ohgaki
[email protected]