Re: Re: Session: deprecating create_sid() method and add createSid()?

From: Date: Tue, 18 Mar 2014 07:44:07 +0000
Subject: Re: Re: Session: deprecating create_sid() method and add createSid()?
References: 1 2 3 4  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
Hi!

> If user uses undocumented interface (SessionIdInterface) they would have to 
> implement both createSid() and create_sid(). Alternatively, we may introduce
> temporary interface for create_sid(). Or keep it undocumented and rename it
> in 5.6 only.

Doing to all this length for what? To rename a function? Looks hardly
worth it.

> Fortunately, current manual
> http://jp2.php.net/manual/en/function.session-set-save-handler.php
> is incomplete. It does not mention create_sid() and it's interface. It
> does not 
> use interface for detailed version of example, too.

It doesn't matter - it's there for 10 releases, so it's part of the API.

> What is your opinion?

My opinion it would be the best if we could support both and deprecate
create_sid in 5.6, but if it's hard to do cleanly, then leave it alone.

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227


Thread (39 messages)

« previous php.internals (#73260) next »