Hi Nikita,
On Tue, January 28, 2014 21:51, Nikita Popov wrote:
> On Tue, Jan 28, 2014 at 9:33 PM, Pierre Joye <[email protected]>
> wrote:
>
>
>>> Just to clarify my vote: I voted "No" on the RFC, but only because I
>>>
>> think
>>> the major extension source API break is better suited to PHP 6 than
>>> PHP
>>> 5.6. I fully support merging this into master, as the first change for
>>>
>> PHP
>>
>>> 6.
>>>
>>
>> Sad. As the work for pecl extensions is really not as large as you
>> think, fairly straight forward. The vote for php6 is not running now.
>> There is no option for PHP 6 as what can be done in php 6 internally
>> is much larger and would allow more breakage. On the other side, we
>> provide options to minimize the work for the extensions developers in
>> order of magnitude smaller than the changes we introduced in the past
>> for the OO APIs for example. Anyway, sad that you voted no for
>> something as important than true 64bit support.
>>
>
> Maybe I'm indeed overestimating the impact. Could you please link to the
> source-code for a PECL (or other third-party) extension that was ported to
> be compatible with the new API, so people can see the actual impact this
> makes? (Hopefully some ext that requires compat across multiple versions
> like 5.3+ and has non-trivial amount of code and functions, like a few
> dozen.) I couldn't find an example in RFC, but maybe I just missed it.
> Only
> saw small snippets in there.
>
to see an impact, it's enough to take a look at the diff between
str_size_and_int64 and 5.6 or master branches. For easy ones see shmop and
alike. For bigger impact the porting of substr() will be interesting.
Generally ext/standard is what you can imagine as a huge piece of porting.
You also can take a look at ext/oci8 where Chis already accomplished the
compatibility (except zpp). I of course use real extensions to develop the
porting path and I'll have to support a number of extensions on PECL and
even one on sf.net. The replace.php has already some regex to work the zpp
specs, so generally it'll decrease the porting routine more and more.
Though I don't think it's enough to just to see the impact. I could only
suggest you to try yourself and give your feedback. The porting tool and
doc are being improved every day as we speak, and everyone's feedback is
worth a mint! Especially if you really think this patch can be useful. I
think this is the only way to understand the effort. Several people have
already tried it and gave their improvement thoughts which was
implemented. Time is anyway what we still have for 5.6 if the decision is
met and we stand behind it.
Best regards
Anatol