On Thu, 30 Jan 2014, Christopher Jones wrote:
> On 1/30/14 8:16 PM, Stephen Zarkos wrote:
>
> > At this point I'm not really sure what numbers you need.
>
> Linux 64 bit results would have been useful to make sure there aren't
> any regressions on arguably the most popular environment.
IMO, *any* performance degredation for this most popular environment
should mean that the patch should not make it in.
> This is because the implementation touches nearly every source file
> and alters the string length of the most fundamental data object in
> PHP's implementation (the zval).
I know in the past we have been really reluctant to increase the zval
change. F.e. with the GC change we added bitfields. I think it might be
less of an issue now to increase the size, as Dmitry has I think
improved the allocator quite a bit, but it is by no means something that
should be glossed over lightly.
cheers,
Derick
--
http://derickrethans.nl | http://xdebug.org
Like Xdebug? Consider a donation: http://xdebug.org/donate.php
twitter: @derickr and @xdebug
Posted with an email client that doesn't mangle email: alpine